Upgrade phpcodesniffer-composer-installer #36791

fredden · 2023-01-30T12:30:25Z

Description

dealerdirect/phpcodesniffer-composer-installer has now reached its first stable version. See https://github.com/PHPCSStandards/composer-installer/releases/tag/v1.0.0 for details.

Manual testing scenarios

There are no functional changes between these two versions.

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Upgrade phpcodesniffer-composer-installer #36913: Upgrade phpcodesniffer-composer-installer

m2-assistant · 2023-01-30T12:30:28Z

Hi @fredden. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

magento-automated-testing · 2023-01-30T12:30:54Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik

Hi @fredden Thanks for your update.
Please review my comment

Den4ik · 2023-02-06T08:10:57Z

composer.json

@@ -90,7 +90,7 @@
    },
    "require-dev": {
        "allure-framework/allure-phpunit": "^2",
-        "dealerdirect/phpcodesniffer-composer-installer": "^0.7",
+        "dealerdirect/phpcodesniffer-composer-installer": "^0.7 || ^1.0",


As same as for codding-standard repo PR I believe that "^1.0" will be enough

There's nothing here that's not compatible with ^0.7.0. I've specifically kept this because I expect other packages may take a while to upgrade / allow the new version. If there's something that requires ^0.7, it'll work today, but not after merging if we change this to ^1.0 only. Listing both supported versions means that interoperability with other packages is maintained; Composer will pick the "best" version, which is typically the highest mutually-supported version. If we use ^1.0 only here, then we're forcing others to upgrade their packages in order for their coding standard to be used in conjunction with this product.

Den4ik

Failed test is not related to changes

glo30253 · 2023-02-14T11:15:35Z

@magento run Functional Tests B2B

magento-automated-testing · 2023-02-14T11:15:41Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

glo30253 · 2023-02-15T06:07:06Z

Hi @fredden,@Den4ik
Thanks for the collaboration & contribution!

✔️ QA Passed

Manual Scenario Steps
Before: ✖️
We have checked with 2.4-develop and phpcodesniffer was 0.7.2 version

After: ✔️
We have checked with PR changes and phpcodesniffer composer installer upgrading from 0.7.2 t0 1.0

magento-automated-testing · 2023-02-15T06:13:16Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2023-02-15T06:25:34Z

As per above comment, moving it to Merge In Progress.

Thank you!

engcom-Lima · 2023-02-23T10:32:18Z

@magento create issue

engcom-Charlie · 2023-09-11T09:38:26Z

Hi @fredden,

Based on this comment, can we close this PR.

Thank you!

fredden · 2023-09-11T10:58:54Z

@engcom-Charlie, Adobe needs to decide if they want to accept the breaking changes introduced by @glo71317 in d337684 (in which case this pull request should be closed), or not (in which case this pull request should be merged as was the plan since 15th February 2023).

glo71317 · 2023-09-12T11:47:49Z

@engcom-Charlie, Adobe needs to decide if they want to accept the breaking changes introduced by @glo71317 in d337684 (in which case this pull request should be closed), or not (in which case this pull request should be merged as was the plan since 15th February 2023).

Hi @fredden, i don't think there is any breaking changes, And also not forcing to any other vendor and customer to update the dependency in current magento version which they are using they can continue without any breaking changes, As per my understanding If they will upgrade with current version to upcoming 2.4.7-beta2 they can do without any breaking changes.
If you are facing any issue please let me know what are the breaking changes introduced by d337684

fredden · 2023-12-27T12:17:24Z

please let me know what are the breaking changes introduced by d337684

I have already articulated this. Please see #36791 (comment)

That's a breaking change. (See discussion here: #36791 (comment).)

magento-automated-testing · 2023-12-27T12:18:00Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Den4ik · 2023-12-27T18:29:33Z

@glo30253 I'm agree with @fredden
We can't guarantee that thouthand's of Magento modules will work with this update. in this case Magento upgrade could break the stores. Make sense support both versions in the next minor release and remove old version at the second minor release. It provide some time to developers for update.

magento-automated-testing · 2024-01-19T17:10:53Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

glo71317 · 2024-01-25T14:00:47Z

@fredden @Den4ik As per discussion with PO and Engineering Manager.
We have to downgrade at "dealerdirect/phpcodesniffer-composer-installer": "^1.0” to "dealerdirect/phpcodesniffer-composer-installer": "^0.7”

@Den4ik please update the pr based on above discussion if you want to deliver these changes else we will do and cancel this PR?

fredden · 2024-01-25T14:11:55Z

@glo71317 you introduced the breaking change in d337684. This pull request fixes the breaking part of that commit by re-introducing support for versions 0.7.x of this package. Before your change, this pull request was already backwards-compatible. Please can you arrange for this to be merged, as was the intention back in February 2023. (See #36791 (comment))

Den4ik · 2024-01-25T14:21:10Z

@glo71317 @fredden provided enough comment

glo71317 · 2024-01-26T07:52:33Z

@fredden @Den4ik Okay make sense thanks for your contribution.
@Indraniks Can you proceed for merging this pr?

Den4ik · 2024-01-26T09:33:58Z

@glo71317 Great, thanks for conversation

engcom-Charlie · 2024-01-29T06:31:36Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

magento-automated-testing · 2024-01-29T06:31:46Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Charlie · 2024-01-29T14:48:54Z

As the this comment, and as the PR is already been tested prior hence moving this PR to Merge in Progress.

engcom-Charlie · 2024-02-26T04:09:55Z

This PR got merged in a2519ca hence closing this now.

hostep · 2024-02-26T09:50:25Z

@engcom-Charlie: please link to the publicly visible repo, it should be this link: a2519ca

Upgrade phpcodesniffer-composer-installer

7e80263

m2-github-services added Partner: Fisheye partners-contribution Pull Request is created by Magento Partner labels Jan 30, 2023

engcom-Charlie added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 31, 2023

m2-community-project bot added the Progress: pending review label Jan 31, 2023

fredden mentioned this pull request Feb 1, 2023

Simplify installation instructions magento/magento-coding-standard#436

Open

Den4ik reviewed Feb 6, 2023

View reviewed changes

m2-community-project bot assigned Den4ik Feb 6, 2023

m2-community-project bot added Progress: review and removed Progress: pending review labels Feb 6, 2023

Den4ik approved these changes Feb 6, 2023

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Feb 6, 2023

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Feb 15, 2023

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Feb 15, 2023

fredden added 2 commits September 25, 2023 22:34

Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer

0ddf6b7

Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer

740a73c

Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer

6537888

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Jan 29, 2024

fredden added 3 commits February 6, 2024 17:32

Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer

397b196

Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer

708d0f2

Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer

2ef3c63

engcom-Charlie closed this Feb 26, 2024

m2-community-project bot removed the Progress: accept label Feb 26, 2024

fredden deleted the phpcs-installer branch February 26, 2024 10:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade phpcodesniffer-composer-installer #36791

Upgrade phpcodesniffer-composer-installer #36791

fredden commented Jan 30, 2023 •

edited by m2-assistant bot

Loading

m2-assistant bot commented Jan 30, 2023

magento-automated-testing bot commented Jan 30, 2023

Den4ik left a comment

Den4ik Feb 6, 2023

fredden Feb 6, 2023

Den4ik Feb 6, 2023

Den4ik left a comment

glo30253 commented Feb 14, 2023

magento-automated-testing bot commented Feb 14, 2023

glo30253 commented Feb 15, 2023 •

edited

Loading

magento-automated-testing bot commented Feb 15, 2023

engcom-Charlie commented Feb 15, 2023

engcom-Lima commented Feb 23, 2023

engcom-Charlie commented Sep 11, 2023

fredden commented Sep 11, 2023

glo71317 commented Sep 12, 2023

fredden commented Dec 27, 2023

magento-automated-testing bot commented Dec 27, 2023

Den4ik commented Dec 27, 2023

magento-automated-testing bot commented Jan 19, 2024

glo71317 commented Jan 25, 2024 •

edited

Loading

fredden commented Jan 25, 2024

Den4ik commented Jan 25, 2024

glo71317 commented Jan 26, 2024

Den4ik commented Jan 26, 2024

engcom-Charlie commented Jan 29, 2024

magento-automated-testing bot commented Jan 29, 2024

engcom-Charlie commented Jan 29, 2024 •

edited

Loading

engcom-Charlie commented Feb 26, 2024

hostep commented Feb 26, 2024

Upgrade phpcodesniffer-composer-installer #36791

Upgrade phpcodesniffer-composer-installer #36791

Conversation

fredden commented Jan 30, 2023 • edited by m2-assistant bot Loading

Description

Manual testing scenarios

Contribution checklist

Resolved issues:

m2-assistant bot commented Jan 30, 2023

magento-automated-testing bot commented Jan 30, 2023

Den4ik left a comment

Choose a reason for hiding this comment

Den4ik Feb 6, 2023

Choose a reason for hiding this comment

fredden Feb 6, 2023

Choose a reason for hiding this comment

Den4ik Feb 6, 2023

Choose a reason for hiding this comment

Den4ik left a comment

Choose a reason for hiding this comment

glo30253 commented Feb 14, 2023

magento-automated-testing bot commented Feb 14, 2023

glo30253 commented Feb 15, 2023 • edited Loading

magento-automated-testing bot commented Feb 15, 2023

engcom-Charlie commented Feb 15, 2023

engcom-Lima commented Feb 23, 2023

engcom-Charlie commented Sep 11, 2023

fredden commented Sep 11, 2023

glo71317 commented Sep 12, 2023

fredden commented Dec 27, 2023

magento-automated-testing bot commented Dec 27, 2023

Den4ik commented Dec 27, 2023

magento-automated-testing bot commented Jan 19, 2024

glo71317 commented Jan 25, 2024 • edited Loading

fredden commented Jan 25, 2024

Den4ik commented Jan 25, 2024

glo71317 commented Jan 26, 2024

Den4ik commented Jan 26, 2024

engcom-Charlie commented Jan 29, 2024

magento-automated-testing bot commented Jan 29, 2024

engcom-Charlie commented Jan 29, 2024 • edited Loading

engcom-Charlie commented Feb 26, 2024

hostep commented Feb 26, 2024

fredden commented Jan 30, 2023 •

edited by m2-assistant bot

Loading

glo30253 commented Feb 15, 2023 •

edited

Loading

glo71317 commented Jan 25, 2024 •

edited

Loading

engcom-Charlie commented Jan 29, 2024 •

edited

Loading